Enables rdkit-structure-renderer.js in Jupyter Lab and Notebook #5132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ptosco : the test failure in the limitdependencies build looks real: |
proposed refactoring: move InteractiveRenderer to a module
greglandrum
added a commit
that referenced
this pull request
Mar 28, 2022
* wip * enables usage of rdkit-structure-renderer.js in Jupyter Lab and Jupyter Notebook * fix CI issue * proposed refactoring: move InteractiveRenderer to a module * minor changes Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com> Co-authored-by: greg landrum <greg.landrum@gmail.com>
Merged
ptosco
pushed a commit
to ptosco/rdkit
that referenced
this pull request
Jun 21, 2022
This was referenced Jun 21, 2022
Merged
greglandrum
pushed a commit
that referenced
this pull request
Jun 22, 2022
greglandrum
pushed a commit
that referenced
this pull request
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be further improved (particularly the documentation, which is non-existent at the moment), but I wished to get it to you as early of possible so you can start having a look.
There is a Jupyter Notebook that can be used for testing: