Check architecture of the target system to optimise popcnt #5182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglandrum
reviewed
Apr 16, 2022
CMakeLists.txt
Outdated
| @@ -66,9 +66,9 @@ set(RDK_BOOST_VERSION "1.58.0") | |||
|
|
|||
| if(NOT MSVC) | |||
| if(RDK_OPTIMIZE_POPCNT) | |||
| if(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64") | |||
| if(CMAKE_HOST_PROCESSOR STREQUAL "aarch64") | |||
There was a problem hiding this comment.
Shouldn't this also be CMAKE_SYSTEM_PROCESSOR?
There was a problem hiding this comment.
Yes, that was wrong 🤦 Fixed, thanks
When you have to make decisions based on the capabilities of the system, you must check the *target* system, not the host one. It doesn't make any sense to look at the host system when doing cross-compilation from a different architecture.
giordano
force-pushed
the
mg/cmake-popcnt
branch
from
824d905
to
7a1f7a4
Compare
greglandrum
approved these changes
Apr 17, 2022
greglandrum
pushed a commit
that referenced
this pull request
Apr 25, 2022
When you have to make decisions based on the capabilities of the system, you must check the *target* system, not the host one. It doesn't make any sense to look at the host system when doing cross-compilation from a different architecture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
When you have to make decisions based on the capabilities of the system, you
must check the target system, not the host one. It doesn't make any sense to
look at the host system when doing cross-compilation from a different
architecture.