Fixes array overflow in FMCS code #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bp-kelley
reviewed
Apr 16, 2022
| @@ -157,8 +157,8 @@ void MaximumCommonSubgraph::init() { | |||
| labels.clear(); | |||
| currentLabelValue = 1; | |||
| nq = QueryMolecule->getNumBonds(); | |||
| QueryBondLabels.resize(nq); | |||
| for (size_t aj = 0; aj < nq; aj++) { | |||
There was a problem hiding this comment.
I think using "aj" as a bond iterator was the recipe for disaster here.
nice catch.
greglandrum
changed the title
greglandrum
pushed a commit
that referenced
this pull request
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing with address sanitization on Python tests (fortunately, asan is way faster than valgrind when working around Python).
Some Python test revealed an array overflow in line 204 of Code/GraphMol/FMCS/MaximumCommonSubgraph.cpp. I'm not familiar with the FMCS code, but this looks like a bug to me.
Sadly, I don't know how to write a test that would expose this.