Fix duplicate non thread safe check in VarianceDataForLabel #5212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglandrum
requested changes
Apr 29, 2022
Comment on lines
241
to
247
| #ifdef RDK_THREADSAFE_SSS | ||
| const std::lock_guard<std::mutex> lock(groupMutex); | ||
| const std::lock_guard<std::mutex> lock(groupMutex); | ||
| #endif | ||
| if (rgroupData->fingerprint == nullptr) { | ||
| addFingerprintToRGroupData(rgroupData); | ||
| } | ||
| if (rgroupData->fingerprint == nullptr) { | ||
| addFingerprintToRGroupData(rgroupData); | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this leaves the mutex alive longer than it needs to be.
You can reproduce the original lifetime of the mutex by introducing a local scope:
{
#ifdef RDK_THREADSAFE_SSS
const std::lock_guard<std::mutex> lock(groupMutex);
#endif
if (rgroupData->fingerprint == nullptr) {
addFingerprintToRGroupData(rgroupData);
}
}
greglandrum
pushed a commit
that referenced
this pull request
Jun 2, 2022
* fix non thread safe check in VarianceDataForLabel::addRgroupData() * scope mutex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another detection flagged by the thread sanitizer.
In this case, there's a data race condition in
rgroupData->fingerprint, which is updated insideaddFingerprintToRGroupData(). Maybe not a big issue due to the duplicated check, but it's still good to get it fixed by removing the duplicate check outside the mutex.