Make the aliphatic imine rule more closely match the definition in the paper #5270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule for imines in the paper from Sitzmann et al that we use for tautomer enumeration looks like this:
Our rules for this are:
The result is that our rules match this structure:
and transform it to this one, which is aromatic:
The back-transform doesn't apply to the aromatic structure, so we have an asymmetry.
The original reaction SMARTS for Rule 3:
should not match this molecule at all since they require that the only non-H substituent on the N atom is an aromatic atom.
This PR adjusts the SMARTS definitions for aliphatic imines in order to reflect this requirement.
This is clearly a bug fix, but since it may have a non-trivial impact on the number of tautomers generated I'm not sure if we want to do it in a patch release. Maybe it's better to hold it for 2022.09.1; what do you think?
Thanks to @rachelnwalker for pointing this one out.