Fix integer overflow in RGroupDecomposition strategy GA #5460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jones-gareth please take a look at this fix. We've been having some hanging issues (well, effectively hanging issues) that this seems to resolve. |
bp-kelley
commented
Jul 26, 2022
bp-kelley
changed the title
|
I don't have a test case here as (a) it was large and (b) I noticed it on in house data |
|
@greglandrum code is updated with std::min |
|
@greglandrum any chance on a merge for this one? |
Sure. I was just waiting to see if @jones-gareth had any comments. |
greglandrum
pushed a commit
that referenced
this pull request
Aug 4, 2022
* Fix integer overflow in numPermutations * Use Greg's suggestion to simplify code Co-authored-by: Brian Kelley <bkelley@relaytx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix an issue where the number of permutations would overflow in the GA and be set to 0.
This caused the code to fallback to the Exhaustive search which basically hangs at this point.