Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pains from wehi_pains.csv #560

Merged
merged 1 commit into from
Aug 10, 2015

Conversation

bp-kelley
Copy link
Contributor

The update_pains.py in the FilterCatalog directory should update the Filter Catalog with the new set of pains in rdkit/data/PAINS, this is currently not automated.

greglandrum added a commit that referenced this pull request Aug 10, 2015
@greglandrum greglandrum merged commit 5679fa4 into rdkit:master Aug 10, 2015
@apahl
Copy link
Contributor

apahl commented Aug 18, 2015

@bp-kelley: Brian, thanks a lot for all the work you put into the PAINS filters, this is highly appreciated.
Could you change update_pains.py, so that it would be also Python3 compatible (print function...). If you want to, I can also generate a pull request.
Kind regards,
Axel

@apahl
Copy link
Contributor

apahl commented Aug 18, 2015

also, I just noticed, the path should be ../../../Data/Pains/wehi_pains.csv instead of ../../../data/PAINS/wehi_pains.csv (at least on Linux, case matters).
Kind regards,
Axel

@bp-kelley
Copy link
Contributor Author

Will do. Thanks for the heads up, osx's case insensitivity is a silly, silly thing. We recently had a problem with git and two file names that only differed by case :)


Brian Kelley

On Aug 18, 2015, at 8:48 AM, Axel Pahl notifications@github.com wrote:

@bp-kelley: Brian, thanks a lot for all the work you put into the PAINS filters, this is highly appreciated.
Could you change update_pains.py, so that it would be also Python3 compatible (print function...). If you want to, I can also generate a pull request.
Kind regards,
Axel


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants