Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid incurring into division by zero in normalizeDepiction #5619

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

ptosco
Copy link
Contributor

@ptosco ptosco commented Oct 5, 2022

Small fix to avoid incurring into division by zero, e.g., when coordinates of the molecule are all zero.

@greglandrum greglandrum changed the title Avoid incurring into division by zero Avoid incurring into division by zero in normalizeDepiction Oct 6, 2022
@greglandrum greglandrum added the bug label Oct 6, 2022
@greglandrum greglandrum added this to the 2022_09_1 milestone Oct 6, 2022
Copy link
Member

@greglandrum greglandrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greglandrum greglandrum merged commit 8d53b17 into rdkit:master Oct 6, 2022
@ptosco ptosco deleted the normalize_divbyzero branch October 6, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants