Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow properties to be displayed in jupyter when 3D rendering is enabled #5624

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

greglandrum
Copy link
Member

There's a bad interaction in the notebook integration between the property display and the 3D molecule rendering: if 3d molecule rendering is enabled then no properties are displayed, even if a given molecule doesn't have a 3D conformer.

This fixes that.

There's also one reformatting chunk here

@greglandrum greglandrum added the bug label Oct 6, 2022
@greglandrum greglandrum added this to the 2022_09_1 milestone Oct 6, 2022
Copy link
Contributor

@ptosco ptosco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@greglandrum greglandrum merged commit a6e38e2 into rdkit:master Oct 7, 2022
@greglandrum greglandrum deleted the fix/no_props_in_jupyter branch October 7, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants