Allow setting custom FREETYPE_LIBRARY/FREETYPE_INCLUDE_DIRS through CMake #5730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…air of FREETYPE_INCLUDE_DIRS/FREETYPE_LIBRARIES vars (thus consolidating the mechanism that was already used my emscripten builds). This allows to specify them as -D flags on the CMake line giving a bit more flexibility.
|
@ptosco :what's your take on how I should tag this (bug/enhancement) and which milestone I should assign it to? |
|
@greglandrum I would consider it a bug fix for 2022.09.2 - the way it previously worked prevented setting an explicit path to FreeType library and headers, which can be considered a bug given that's usually possible for most if not all libraries. |
greglandrum
pushed a commit
that referenced
this pull request
Nov 23, 2022
…air of FREETYPE_INCLUDE_DIRS/FREETYPE_LIBRARIES vars (thus consolidating the mechanism that was already used my emscripten builds). (#5730) This allows to specify them as -D flags on the CMake line giving a bit more flexibility. Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have just upgraded to our latest internal
condaenvironment and noticed that thecondaFreeType library has an additional dependency onlibXauwhich apparently is not correctly captured by CMake'sFindFreetype. So I need to manually specify the dependency by settingHowever, for this to work I had to replace the
Freetype::FreetypeIMPORTEDtarget with the standard pair ofFREETYPE_INCLUDE_DIRS/FREETYPE_LIBRARIESvars (thus consolidating the mechanism that was already used my emscripten builds).