Set emsdk path for freetype in emscripten builds #5857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set emsdk path for freetype - add compilation flag to enable building with latest clang compilers
greglandrum
approved these changes
Dec 12, 2022
greglandrum
pushed a commit
that referenced
this pull request
Feb 23, 2023
- set emsdk path for freetype - add compilation flag to enable building with latest clang compilers Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on something completely different I realized what was wrong with
libfreetype:emscriptencompiles its own version oflibfreetypeand caches it withinemsdk. Pointingcmaketo theemsdkversion oflibfreetypesolves all problems and it is possible to build again with the latestemsdk.Since the latest
emsdkis based onclang16the-Wno-enum-constexpr-conversionflag is needed to buildboost.emsdkemsdkpath forfreetypeclangcompilers