updates to PandasTools.LoadSDF #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDF loader is now about 2.4x the original performance. If the filename ends with ".gz" (case-insenitive) then the file will be opened as a gzip file. If a file object is passed in, then don't close it on exit - the caller is responsible for that. If the molecule is empty, return an empty data frame instead of None.
greglandrum
added a commit
that referenced
this pull request
Sep 4, 2015
updates to PandasTools.LoadSDF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDF loader is now about 2.4x the original performance.
If the filename ends with ".gz" (case-insenitive) then the file will be opened as a gzip file.
Support unicode filenames as well as byte filenames.
If a file object is passed in, then don't close it on exit - the caller is responsible for that.
If the molecule is empty, return an empty data frame instead of None.