Remove and from C++ headers
#6003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`and` is a C++ keyword, but it isn't supported by default on some compilers (msvc). I'd like to disable it on _all_ platforms in Schrodinger builds so that people don't accidentally post code that fails on a single platform. However, that means external headers need to use `&&` and `||` instead of `and` and `or`, even in platform-specific code.
|
I used to do this when going from python to c++ as well, Gcc should not accept this in my opinion! |
|
yeah, I'm gonna turn on |
greglandrum
pushed a commit
that referenced
this pull request
Feb 23, 2023
`and` is a C++ keyword, but it isn't supported by default on some compilers (msvc). I'd like to disable it on _all_ platforms in Schrodinger builds so that people don't accidentally post code that fails on a single platform. However, that means external headers need to use `&&` and `||` instead of `and` and `or`, even in platform-specific code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
andis a C++ keyword, but it isn't supported by default on some compilers (msvc). I'd like to disable it on all platforms in Schrödinger builds so that developers don't accidentally post code that fails on a single platform.However, that means external headers need to use
&&and||instead ofandandor, even in platform-specific code.