Fix some minor leaks #6029
Merged
Fix some minor leaks #6029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will try to incorporate this into the next patch release too, but that may not completely work due to the extensive changes in the fingerprint generator code. Since these are minor problems, that won't be a giant tragedy |
Sounds good to me. |
greglandrum
pushed a commit
that referenced
this pull request
Feb 23, 2023
* fix deserializing leaks ringinfo * fix leak in FingerprintGenerator * fix leak in MolStandardize test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some minor leaks I found running asan on the tests:
Code/GraphMol/MolStandardize/test1.cpp: just one Mol that wasn't being deallocated.Code/GraphMol/Fingerprints/FingerprintGenerator.cpp:atomInvariantsandbondInvariantswere not being cleaned up when something fails in downstream code.Code/GraphMol/ROMol.cpp:ROMol::load()is not a constructor, so it can only be called on already initialized mols, so when we callinitMol()(I assume that to reset properties and ring info,dp_ringInfois already allocated, and leaks.