Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppVeyor and Travis UnitTests #636

Merged

Conversation

bp-kelley
Copy link
Contributor

UnitTestSimilarityMaps was failing on travis because no XWindow display was set. This forces matplotlib to use the Agg renderer when the DISPLAY variable isn't set which allows the test to pass but perhaps has side-effects.

@bp-kelley
Copy link
Contributor Author

This was the reason the travis python 2.7 was failing I believe.

@rvianello
Copy link
Contributor

I think the python 2.7 build on travis-ci is failing because some tests (that are not executed for python 3.4) are now requiring pandas at build time (it was used to be optional).

@bp-kelley
Copy link
Contributor Author

I'm fixing this as well, the X-display was on my VM so I just fixed it
first.
Interestingly, the travis build is installing pandas 0.17.0 so I'm
investigating why this is failing as well.

On Mon, Oct 12, 2015 at 10:30 AM, Riccardo Vianello <
notifications@github.com> wrote:

I think the python 2.7 build on travis-ci is failing because some tests
(that are not executed for python 3.4) are now requiring pandas at build
time (it was used to be optional).


Reply to this email directly or view it on GitHub
#636 (comment).

@bp-kelley
Copy link
Contributor Author

the pandas version location changed in 0.17. We should use version not
pandas.version.version

On Mon, Oct 12, 2015 at 11:43 AM, Brian Kelley fustigator@gmail.com wrote:

I'm fixing this as well, the X-display was on my VM so I just fixed it
first.
Interestingly, the travis build is installing pandas 0.17.0 so I'm
investigating why this is failing as well.

On Mon, Oct 12, 2015 at 10:30 AM, Riccardo Vianello <
notifications@github.com> wrote:

I think the python 2.7 build on travis-ci is failing because some tests
(that are not executed for python 3.4) are now requiring pandas at build
time (it was used to be optional).


Reply to this email directly or view it on GitHub
#636 (comment).

@bp-kelley
Copy link
Contributor Author

Pulled in riccardo's fix to make this a roll up for appveyor and travis builds. Cross your fingers!

@bp-kelley
Copy link
Contributor Author

Yay! Appveyor is back to the land of the living :) Thanks @rvianello!

@bp-kelley bp-kelley changed the title Fixes Draw tests on linux systems with no X-Display set Fix AppVeyor and Travis UnitTests Oct 12, 2015
greglandrum added a commit that referenced this pull request Oct 13, 2015
@greglandrum greglandrum merged commit 294441c into rdkit:master Oct 13, 2015
@greglandrum
Copy link
Member

Thanks for tracking that down @bp-kelley!

@greglandrum greglandrum added this to the 2015_09_1 milestone Oct 13, 2015
@bp-kelley bp-kelley deleted the fix/pythonTestDirChem-No-X-Display branch March 19, 2016 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants