Fix/python gil release on rdkit threadsafe sss only #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| raise ValueError('Bad core structure') | ||
| ref_mol.GetSubstructMatch(core_mol) | ||
|
|
||
| def sub_match2(): |
There was a problem hiding this comment.
This is really repetitive; couldn't you just have one test function that takes the method to call as an argument?
|
Should we turn on thread safety for testing? |
added 4 commits
October 15, 2015 08:10
|
You got xrange but missed the print statement ;) |
|
damn! |
greglandrum
added a commit
that referenced
this pull request
Oct 15, 2015
…T_THREADSAFE_SSS-only Fix/python gil release on rdkit threadsafe sss only
bp-kelley
deleted the
fix/python-gil-release-on-RDKIT_THREADSAFE_SSS-only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GIL is only released when RDK_BUILD_THREADSAFE_SSS is on.
Additional python treading tests were added (RDK_TEST_MULTITHREADED). These only check for sanity errors (i.e. re-entering the python interpreter when the GIL is released) not the underlying C++ code.