Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identical for-loop variable names #6391

Merged
merged 2 commits into from
May 25, 2023
Merged

Conversation

JLVarjo
Copy link
Contributor

@JLVarjo JLVarjo commented May 24, 2023

Minor cleanup, no effect to functionality: There's a same loop variable name used in nested for-loops in Dict.h. Not a bug but causes compiler warnings.

Code/RDGeneral/Dict.h Outdated Show resolved Hide resolved
Copy link
Member

@greglandrum greglandrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greglandrum greglandrum added the Cleanup Code cleanup and refactoring label May 25, 2023
@greglandrum greglandrum added this to the 2023_09_1 milestone May 25, 2023
@greglandrum greglandrum merged commit 1f7b1ae into rdkit:master May 25, 2023
10 checks passed
@greglandrum
Copy link
Member

Thanks @JLVarjo !

@JLVarjo JLVarjo deleted the cleanup branch July 3, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code cleanup and refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants