Fix a few broken docstrings #6480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Python keywords should not be used as parameter names
|
@greglandrum the failure here is due to the |
greglandrum
requested changes
Jun 22, 2023
yep, I was doing the review as you sent this gentle reminder. :-) |
greglandrum
reviewed
Jun 23, 2023
greglandrum
pushed a commit
that referenced
this pull request
Aug 17, 2023
* - Fix a couple of docstrings that were confusing boost::python - Python keywords should not be used as parameter names * changes in response to review * removed two leftover BOOST_PYTHON_FUNCTION_OVERLOADS --------- Co-authored-by: Tosco, Paolo <paolo.tosco@novartis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boost::python(FromArray, FromStringArray); namely, the comment was being parsed as the parameter name, i.e.:FromArray((MHFPEncoder)vec, (list)Creates a MHFP vector from a list of unsigned integers.) →
_vectjFromStringArray(_(MHFPEncoder)vec, (list)Creates a MHFP vector from a list of arbitrary strings.) →
_vectjfrom)