Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests that weren't being run in testDepictor.py #6486

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

rachelnwalker
Copy link
Contributor

These tests weren't being ran due to an indentation issue. I think that when I wrote these, my formatting was incorrect, and the re-formatting done before the last release accidentally moved all of these tests into another function and skipped them.

Copy link
Member

@greglandrum greglandrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for noticing and fixing this.

@greglandrum greglandrum added this to the 2023_03_3 milestone Jun 23, 2023
@greglandrum greglandrum changed the title Fixed tests that weren't being ran in testDepictor.py Fixed tests that weren't being run in testDepictor.py Jun 23, 2023
@greglandrum greglandrum merged commit 70b8a68 into rdkit:master Jun 23, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants