Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #6499 #6500

Closed
wants to merge 1 commit into from
Closed

fixes #6499 #6500

wants to merge 1 commit into from

Conversation

ptosco
Copy link
Contributor

@ptosco ptosco commented Jun 27, 2023

This PR replaces the deprecated unittest aliases, which apparently were removed in Python 3.12, with their non-deprecated equivalents across all RDKit Python tests.

@ptosco ptosco added bug infrastructure build infrastructure and the like labels Jun 27, 2023
@ptosco ptosco added this to the 2023_03_3 milestone Jun 27, 2023
@ptosco ptosco linked an issue Jun 27, 2023 that may be closed by this pull request
Compatibility with Python-3.12 #6499
Open
@greglandrum
Copy link
Member

@ptosco : I believe that #6304 resolved this.

@greglandrum
Copy link
Member

@ptosco can we go ahead and close this?

@ptosco ptosco closed this Aug 4, 2023
@ptosco
Copy link
Contributor Author

ptosco commented Aug 4, 2023

Yes, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bp-kelley bp-kelley bp-kelley approved these changes

Assignees
No one assigned
Labels
bug infrastructure build infrastructure and the like
Projects
None yet
Milestone
2023_03_3
Development

Successfully merging this pull request may close these issues.

Compatibility with Python-3.12
3 participants
@ptosco @greglandrum @bp-kelley