update windows DLL CI build config #6535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptosco
approved these changes
Jul 14, 2023
greglandrum
added a commit
that referenced
this pull request
Aug 17, 2023
* get the config of the windows DLL builds to match the main windows builds * bump boost version * Update vs_build_dll.yml * sigh... * disable python on that build * add back cairo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The windows DLL CI builds were failing due to an error deep in some python dependency. Rather than tracking that down and pinning things, this just disables the python wrappers for the windows DLL build.
The primary purpose of the DLL builds is to make sure that it's actually possible to build the RDKit in DLL mode on winows (it's easy to forget to add some boilerplate and break this), and we test that python builds work on Windows in another CI configuration, so this change shouldn't affect test coverage.