Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MolEnumerator to C# #6542

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Conversation

jones-gareth
Copy link
Contributor

What does this implement/fix? Explain your changes.

Exposes MolEnumerator and MolBundle to the C# wrapper

Any other comments?

I added a simple test, though we don't have any automated testing for C# yet.

@greglandrum greglandrum added this to the 2023_03_3 milestone Jul 13, 2023
@greglandrum
Copy link
Member

@jones-gareth I'm defining this as a bug instead of a feature enhancement: we forgot to include this functionality in the C# wrappers. Does that seem reasonable to you?

Copy link
Member

@greglandrum greglandrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greglandrum greglandrum merged commit 4099473 into rdkit:master Jul 13, 2023
10 checks passed
@jones-gareth
Copy link
Contributor Author

@jones-gareth I'm defining this as a bug instead of a feature enhancement: we forgot to include this functionality in the C# wrappers. Does that seem reasonable to you?

Sounds good

greglandrum pushed a commit that referenced this pull request Aug 17, 2023
* Include enumerator in C# wrappers

* Add MolBundle to C# and create test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants