Fix vulnerabilities found by fuzzer. #6579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomp-j thanks for the contribution. |
This is an attempt to double check where the test failure is coming from.
Re-adding changes to test tests.
|
Thanks for re-running. I was hoping that was the case - things look better now. |
Yep. If you are ready I will go ahead and do the "review" and merge the fix |
I think we are ready to go! |
|
@thomp-j thanks for the contribution! |
greglandrum
pushed a commit
that referenced
this pull request
Aug 17, 2023
* Fix vulnerabilities found by fuzzer. * Fix Typo in RWMol.cpp * Update RWMol.cpp This is an attempt to double check where the test failure is coming from. * Update RWMol.cpp Re-adding changes to test tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=49783
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=44520
What does this implement/fix? Explain your changes.
(1) During fuzzing, it's possible that one atom object is added to the same Stereo group multiple times. The replaceAtom function only replaces a single occurrence. The code later references the second copy of the atom in the stereo group (which wasn't replaced) which accesses deleted memory. This change replaces all copies of an atom during the replaceAtom process.
(2) Catches situations during fuzzing where index values for text substrings in ParseOldAtomList could go out of range.
Any other comments?