Fix a python 3.12 compatibility issue #7450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bp-kelley
approved these changes
May 17, 2024
greglandrum
added
the
not in release notes
|
Thanks for cleaning up after me @rvianello. I will switch my build envs to python 3.12 in order to try and make sure this doesn't happen again |
|
thank you @greglandrum and no problem, the issue was really trivial. |
greglandrum
pushed a commit
that referenced
this pull request
May 30, 2024
syedzayyan
pushed a commit
to syedzayyan/rdkit
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR fixes a small regression in the compatibility with python 3.12