Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from parent project list doesn't check permissions #572

Closed
m6121 opened this issue Jan 20, 2023 · 2 comments · Fixed by #585
Closed

Import from parent project list doesn't check permissions #572

m6121 opened this issue Jan 20, 2023 · 2 comments · Fixed by #585
Assignees
Labels

Comments

@m6121
Copy link
Member

m6121 commented Jan 20, 2023

Description / Beschreibung

The list of projects in the import from parent project selection displays all parent projects independent of the user permissions.

Expected behaviour / Erwartetes Verhalten

Import from parent project should display only projects where users have permissions to import data.

Steps to reproduce / Schritte zum Reproduzieren

  1. Load the dev fixtures in the latest RDMO Version: python manage.py loaddata ../rdmo/testing/fixtures/*
  2. Log in to manager account.
  3. Open Project "Child 1" or "Child 11"
  4. List contains "Parent" although user does not have permissions.
  5. When chosing "Parent" and trying to get to next step, RDMO displays "Forbidden", but I think it would be nicer if the option would not be present in the list.
@m6121 m6121 added the type:bug label Jan 20, 2023
@MyPyDavid
Copy link
Member

Do you mean the project that is called "Parent" in the Project hierarchy of Child1 or Child11 that is "Forbidden" for Manni Manager?
I think so too that this project "Parent" should not be displayed (in the import dropdown and in the project header hierarchy) since the user "manager" is not even a member of the project "Parent".
Templates:

@m6121
Copy link
Member Author

m6121 commented Jan 23, 2023

Do you mean the project that is called "Parent" in the Project hierarchy of Child1 or Child11 that is "Forbidden" for Manni Manager?

Yes, exactly! Sorry for the confusing description, I edited my issue.

@m6121 m6121 self-assigned this Feb 14, 2023
@m6121 m6121 linked a pull request Feb 21, 2023 that will close this issue
jochenklar added a commit that referenced this issue Feb 23, 2023
…-permissions

Fix #572 Import parent permissions
@triole triole closed this as completed in 3998b3e Feb 23, 2023
CalamityC pushed a commit to CalamityC/rdmo that referenced this issue Nov 23, 2023
CalamityC pushed a commit to CalamityC/rdmo that referenced this issue Nov 23, 2023
…mport-parent-permissions

Fix rdmorganiser#572 Import parent permissions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants