Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandoc versionen > 2.0 dropped --reference-odt/docx #124

Merged
merged 2 commits into from May 23, 2019

Conversation

BlackLotus
Copy link
Contributor

@BlackLotus BlackLotus commented Mar 26, 2019

The alternative would be to check the pandoc version and use parameters depending on that.
Better solution would be to simply raise the requirement to pandoc >2

@BlackLotus BlackLotus changed the title pandoc versionen über 2.0 können --reference-odt/docx nicht mehr pandoc versionen > 2.0 dropped --reference-odt/docx Mar 26, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.863% when pulling 2444517 on BlackLotus:master into 8eac88b on rdmorganiser:master.

@coveralls
Copy link

coveralls commented Mar 26, 2019

Coverage Status

Coverage decreased (-0.4%) to 84.485% when pulling d806305 on BlackLotus:master into 8eac88b on rdmorganiser:master.

@jochenklar
Copy link
Member

Hi, thanks for the PR. I think Debian 9 and Centos 7 ship still with Pandoc 1.x. I think the pandoc python wrapper has a function to get the version. We will look into it (soon).

@BlackLotus
Copy link
Contributor Author

Updated the pull request to check the pandoc version.
I checked against 1.x to fallback to the old way, everything else is "new".
I guess support 1.x is still ok, but if someone has 0.x he/she will have to update. Future releases should work (unless they again change the syntax)

@triole
Copy link
Member

triole commented May 23, 2019

Approved.

@triole triole merged commit a3868ce into rdmorganiser:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants