Refactor autocomplete #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jochenklar
force-pushed
the
refactor_autocomplete
branch
from
8224732
to
6a9172e
Compare
MyPyDavid
force-pushed
the
refactor_autocomplete
branch
from
b8a8b22
to
3ac5cc4
Compare
|
I've add a question with the the |
MyPyDavid
force-pushed
the
refactor_autocomplete
branch
from
3ac5cc4
to
6a9172e
Compare
|
no, that breaks all the import tests and requires a lot of refactoring of tests and fixtures I think.. |
jochenklar
force-pushed
the
dev-2.1.0
branch
from
d8dbae1
to
6cc0dbd
Compare
MyPyDavid
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some behavior for the autocomplete widget and adds a new
freeautocompletewidget which can also store arbitrary inputs. The values are then usingtextand notoptionto store the input, just like regular text inputs.Related issue: #600