-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: modernize ruff config #935
Conversation
nice, thanks @afuetterer! Should we not make a |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
No please put everything in |
This comment was marked as resolved.
This comment was marked as resolved.
the more |
This comment was marked as resolved.
This comment was marked as resolved.
The idea of the pyproject.toml is that you can put almost everything in it and not clutter your repo's root with files. sadly it does not work for everything. |
Thanks for fixing the ruff issues @MyPyDavid |
rebased on dependency-updates |
still open
Is there a way to get and post the test summary somewhere else via the github action? (for when it fails) |
What do you mean? |
No, I mean the failed test summary in general. Could it be posted in the actions summary for example (as a convenience)? This |
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Sure, that is possible. Naming was done hacky as well, feel free to rename. Can you open an issue about that? If this PR is done, lets merge it into dependency-updates and deal with the other issue seperately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
Description
The ruff project deprecated sections under
[tool.ruff]
. You need to have e.g.[tool.ruff.lint]
.See: https://docs.astral.sh/ruff/configuration/
Types of Changes
Checklist