Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test that the package lint and pre-commit versions first #939

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

afuetterer
Copy link
Member

@afuetterer afuetterer commented Mar 12, 2024

Description

Related issue: #938

  • remove commit test if test run fails early (only for demonstration purposes)

Types of Changes

  • Other (please describe): Maintenance, CI

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • All new and existing tests passed.

@afuetterer afuetterer marked this pull request as draft March 12, 2024 13:51
@afuetterer
Copy link
Member Author

Can you have a look at the failed test run @MyPyDavid?
https://github.com/rdmorganiser/rdmo/actions/runs/8250046705

There is an annotation under Test (Python: 3.12, DB: postgres): rdmo/core/tests/test_package_status.py#L48.

Is this what you wanted?

@MyPyDavid
Copy link
Member

yes exactly! nice 😄 🙏

Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
some magic is in the https://github.com/pytest-dev/pytest-github-actions-annotate-failures

requesting changes for removing the extra commit ;)

Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@MyPyDavid MyPyDavid merged commit 0872da6 into rdmorganiser:dependency-updates Mar 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests that check the package lint and pre-commit versions should run first
2 participants