Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

977 bug in progress when a section has no pages #978

Merged
merged 2 commits into from
May 14, 2024
Merged

977 bug in progress when a section has no pages #978

merged 2 commits into from
May 14, 2024

Conversation

MyPyDavid
Copy link
Member

@MyPyDavid MyPyDavid commented Apr 22, 2024 •
edited
Loading

Description

Related issue: #977

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
    • bug itself is not yet covered by test
  • All new and existing tests passed.

@MyPyDavid
fix: rename to catalog_section #977
ac615db 
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
@MyPyDavid
tests: add initial tests for project navigation #977
74949f4 
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
@MyPyDavid MyPyDavid linked an issue Apr 22, 2024 that may be closed by this pull request
bug in Progress when a Section has no Pages #977
Closed
@MyPyDavid MyPyDavid changed the base branch from main to dev-2.2.0 April 22, 2024 12:45
@MyPyDavid MyPyDavid added this to the RDMO 2.2.0 milestone Apr 22, 2024
jochenklar
jochenklar approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@jochenklar jochenklar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I fixed the same bug in my interview branch. There were some other issues with the new progress bar, maybe this fixes those as well ...

@MyPyDavid MyPyDavid merged commit 47a504e into dev-2.2.0 May 14, 2024
17 checks passed
@MyPyDavid MyPyDavid deleted the 977-bug-in-progress-when-a-section-has-no-pages branch May 14, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jochenklar jochenklar jochenklar approved these changes

Assignees

@MyPyDavid MyPyDavid

Labels
None yet
Projects
None yet
Milestone
RDMO 2.2.0
Development

Successfully merging this pull request may close these issues.

bug in Progress when a Section has no Pages
2 participants
@MyPyDavid @jochenklar