Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC Event Node: No autocomplete #18

Closed
Sineos opened this issue Aug 30, 2018 · 11 comments
Closed

RPC Event Node: No autocomplete #18

Sineos opened this issue Aug 30, 2018 · 11 comments
Labels
🐛bug Something isn't working

Comments

@Sineos
Copy link
Contributor

Sineos commented Aug 30, 2018

The autocomplete of the RPC event node stopped working for me. For the other Nodes it is still working. Tested in Redmatic v1.2.1

@hobbyquaker hobbyquaker added the 🐛bug Something isn't working label Aug 31, 2018
@hobbyquaker
Copy link
Member

Should be repaired with RedMatic 1.3.0 respectively node-red-contrib-ccu 1.4.1

@Sineos
Copy link
Contributor Author

Sineos commented Aug 31, 2018

Many thanks for the quick reaction.

I might be wrong but I think the old behavior was that the subsequent entries have been filtered according to the previous selection. For example, now all available datapoints for all registered devices are listed regardless of the chosen device or channel.

If I'm wrong call it a feature request ;-)

@Sineos
Copy link
Contributor Author

Sineos commented Aug 31, 2018

And there is a second issue:
Apart from the room, no other select value is remembered when applying and reopening the node.

@hobbyquaker
Copy link
Member

Apart from the room, no other select value is remembered when applying and reopening the node.

Should be fixed in node-red-contrib-ccu 1.4.2 (you can update it via the node-red palette manager)

I might be wrong but I think the old behavior was that the subsequent entries have been filtered according to the previous selection. ... If I'm wrong call it a feature request ;-)

I think that's a feature request, that's implemented in the value node, but it was never implemented in the rpc event node. Isn't a trivial thing, give me some time. Also raises some questions - what to do with RegExp filters? Just ignore them or do you expect them to operate on the filter also?

@Sineos
Copy link
Contributor Author

Sineos commented Aug 31, 2018

Well, I would exclude the RegExp from the filter. If you are able to properly setup the RegExp, you anyway know what you are doing.
The filtering is a great "laziness" feature, because it saves me from looking up the data points in every case, so I would very much appreciate this.

@hobbyquaker hobbyquaker added the 🚀enhancement New feature or request label Aug 31, 2018
@hobbyquaker
Copy link
Member

ok. will do asap ;) can i remove the bug label from this issue (are the select values remembered in 1.4.2?)

@hobbyquaker hobbyquaker changed the title RPC Event Node: No autocomplete RPC Event Node: No autocomplete, Filtering Aug 31, 2018
@Sineos
Copy link
Contributor Author

Sineos commented Aug 31, 2018

Um, I don't want to be a pain in the back, but after updating to 1.4.2 the autocomplete again stopped working :-S

@hobbyquaker
Copy link
Member

narf :)

hobbyquaker added a commit that referenced this issue Aug 31, 2018
@hobbyquaker
Copy link
Member

next try: v1.4.3 :)

@hobbyquaker hobbyquaker removed the 🚀enhancement New feature or request label Aug 31, 2018
@hobbyquaker hobbyquaker changed the title RPC Event Node: No autocomplete, Filtering RPC Event Node: No autocomplete Aug 31, 2018
@Sineos
Copy link
Contributor Author

Sineos commented Aug 31, 2018

narf :)

The same thing we do every night, @hobbyquaker - try to take over the world!

Works 👍

@hobbyquaker
Copy link
Member

download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working
Development

No branches or pull requests

2 participants