New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing logging behavior to only write to $STDOUT by default #39

Merged

rdnewman merged 4 commits into main from fix-logging

Jul 8, 2023

Owner

rdnewman commented Jul 8, 2023

Added new log option to Loba.ts and Loba.val to override and also write to Rails.logger (when available)
Output will always be sent to $STDOUT even if log option is set to true
Updated specs, docs, and CHANGELOG to reflect new behavior
Restructured specs for Loba::Internal::Platform
Updated specs to use more inline mocking, esp., for Loba::Internal::Platform

rdnewman added 4 commits

July 8, 2023 13:03


          add support to output lambda to control logging to Rails (with defaul…

b60a4bb

…t to not log)


          allow ts and val to use new logging control

63c19d0


          verify new forced log works as expected

00b8f30


          updated CHANGELOG for new log behavior

5bc029e

rdnewman merged commit 7257ad7 into main

3 checks passed

rdnewman deleted the fix-logging branch

July 8, 2023 23:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment