Skip to content

Commit

Permalink
Update virtio-vga RPM dependency
Browse files Browse the repository at this point in the history
CentOS9/RHEL QEMU packaging has began to align[1] its packaging layout
to match Fedora's.  This is primarily to improve user experience when
moving from Fedora to CentOS/RHEL.  A part of the impact of this change
is its effect on OSP: the 'virtio-vga' display device has moved to its
own separate package.  Nova supports 'virti-vga'.

Specifically, the "hw-display-virtio-vga.so" file used to be part of
'qemu-kvm-common' RPM, but now it has moved to its own separate package
called 'device-display-virtio-vga'.  So update Nova spec to reflect
this.

Instead of going with a package-based Requires as below:

    Requires(pre): device-display-virtio-vga

We're going with a file-based Requres:

    Requires(pre):  %{_libdir}/qemu-kvm/hw-display-virtio-vga.so

This will transparently allow DNF to handle the updates and install the
renamed package ("device-display-virtio-vga" in tihs case) -- the file
/usr/lib64/qemu-kvm/hw-display-virtio-vga.so used to part of
"qemu-kvm-common", and the same file with same path is now part of the
renamed package.

[1] https://gitlab.com/redhat/centos-stream/src/qemu-kvm/-/merge_requests/60

Thanks: Alfredo Moralejo Alonso for the discussion.

Change-Id: I85bba1c738f3581698a4698cedb3f96d1dacd0b4
Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
  • Loading branch information
kashyapc committed Jan 12, 2022
1 parent 1284b9d commit c19d80b
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions openstack-nova.spec
Expand Up @@ -195,6 +195,12 @@ Requires: xorriso
# groups are guaranteed to exist.
Requires(pre): qemu-kvm-core >= %{qemu_version}
Requires(pre): qemu-kvm-block-rbd >= %{qemu_version}
# The "hw-display-virtio-vga.so" used to be part of 'qemu-kvm-common'
# RPM, however now it has moved to its own separate package called
# 'device-display-virtio-vga'. Having a _libdir-based Requires (instead
# of a package-name based Requires) will allow DNF to transparently
# handle this during updates.
Requires(pre): %{_libdir}/qemu-kvm/hw-display-virtio-vga.so
%if 0%{?rhel} == 8
Requires(pre): qemu-kvm-block-ssh >= %{qemu_version}
%endif
Expand Down

0 comments on commit c19d80b

Please sign in to comment.