-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds fails using ffmpeg n5.0 or greater #603
Comments
Unknown option "--enable-libsvthevc" with building ffmpeg Edit the script line 2333 like this |
It also fails using n5.1-dev so you probably need some kind of check to catch any version greater than 5.0. Also if you set the ffmpeg_git_checkout_version using a git hash it always fails. |
Is this fixed?
…On Mon, Jan 17, 2022 at 3:54 PM echoxxzz ***@***.***> wrote:
It also fails using n5.1-dev so you probably need some kind of check to
catch any version greater than 5.0. Also what happens if you try and set
the ffmpeg_git_checkout_version using a git hash? Maybe the only way around
this going forward is to make libsvthevc a option parameter to the script.
I suspect not a lot of people are using svthevc.
—
Reply to this email directly, view it on GitHub
<#603 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADBUHXT226GNNORZUMXL3UWSMZLANCNFSM5MDODUTA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Not yet... I cannot build master and n5.0.1 in my environment. |
What failure message? I am able to build git master I believe, though
haven't tried it on WSL
…On Sun, Apr 10, 2022 at 2:01 AM Mi2 ***@***.***> wrote:
Not yet...
I cannot build master and n5.0.1 in my environment.
WSL Ubuntu on Win11
—
Reply to this email directly, view it on GitHub
<#603 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADBUCWVEXT2ZVGGVNHOLLVEKDDZANCNFSM5MDODUTA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
n5.0.1 successfully builds on Ubuntu, so I suppose this issue is WSL-related. |
My environment is as follows. When command option below. Error message:
When command option below. . /configure passes.
Can someone please tell me how to solve this problem? |
I was having the same issue and manage to solve it by disabling SVT-HEVC, I don't have a need for that in my build. If that is your case too, you can build it by commenting out lines 2352 and 2378, like:
Seems like the patch for SVT-HEVC is not applying correctly, |
Made it opt-in now, give it a shot :)
…On Tue, Apr 12, 2022 at 8:18 AM jam365 ***@***.***> wrote:
My environment is as follows. Ubuntu 20. WSL on Win11
When command option below. ./cross_compile_ffmpeg.sh
--ffmpeg-git-checkout-version=n5.0.1 --disable-nonfree=n
--build-intel-qsv=y --build-ffmpeg-static=y --compiler-flavors=win64
Error message: When ./configure of ffmpeg
Unknown option "--enable-libsvthevc".
When command option below. ./cross_compile_ffmpeg.sh --disable-nonfree=n
--build-intel-qsv=y --build-ffmpeg-static=y --compiler-flavors=win64
. /configure passes. Error message:
libavcodec/libsvt_hevc.c:571:23: note: (near initialization for 'ff_libsvt_hevc_encoder.cb.decode')
CC libavcodec/libvorbisdec.o
CC libavcodec/libvorbisenc.o
make: *** [ffbuild/common.mak:78: libavcodec/libsvt_hevc.o] Error 1
make: *** Waiting for unfinished jobs....
Can someone please tell me how to solve this problem?
I was having the same issue and manage to solve it by disabling SVT-HEVC
<https://github.com/OpenVisualCloud/SVT-HEVC>, I don't have a need for
that in my build.
If that is your case too, you can build it by commenting out lines 2352
and 2378, like:
# git apply
"$work_dir/SVT-HEVC_git/ffmpeg_plugin/master-0001-lavc-svt_hevc-add-libsvt-hevc-encoder-wrapper.patch"
# config_options+=" --enable-libsvthevc"
Seems like the patch for SVT-HEVC is not applying correctly,
—
Reply to this email directly, view it on GitHub
<#603 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADBUG7MWME4267V35DPXTVEWA4PANCNFSM5MDODUTA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I have successfully built n5.0.1!! |
@rdp am I understanding the fix correctly that the workaround for this is to not build svt at all by passing If so, I would like to be able to selectively exclude only I can file a PR to add this, but I wanted to make sure I understand what the change was that made the svthevc optional |
libvpx is included by default, I think. Are you wanting ffmpeg 5.x with
libsvtav1 and libvpx? The current patch doesn't seem to work with 5.x and
I think it gives libsvtav1? libvpx is enabled by default I believe (auto
detect). Thanks!
…On Thu, Dec 1, 2022 at 2:32 PM Christian Moore ***@***.***> wrote:
Made it opt-in now, give it a shot :)
@rdp <https://github.com/rdp> am I understanding the fix correctly that
the workaround for this is to not build svt at all by passing
--build-svt=n?
If so, I would like to be able to selectively exclude only libsvthevc and
still enable libsvtav1 and libvpx.
I can file a PR to add this, but I wanted to make sure I understand what
the change was that made the svthevc optional
—
Reply to this email directly, view it on GitHub
<#603 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADBUCETACGTUMYVFKKECLWLEKNXANCNFSM5MDODUTA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I don't think libvpx is included by default right now. In the script it is inside the section that only gets called if you enabled SVT. Right now it is around line 2385. I had to move it outside that if (to line 2386) for it to be included on the ffmpeg build. |
If I call the build script with -ffmpeg-git-checkout-version=n5.0 or any greater ffmpeg version the build fails with the following error:
Unknown option: "--enable-libsvthevc".
According to the output from ./configure --help it doesn't even show this as a valid option in 5.0 or greater of ffmpeg.
The text was updated successfully, but these errors were encountered: