Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x265 3.6 x86 asm optimization #738

Merged
merged 3 commits into from
May 17, 2024
Merged

Fix x265 3.6 x86 asm optimization #738

merged 3 commits into from
May 17, 2024

Conversation

AnimMouse
Copy link
Contributor

Fix x265 3.6 x86 asm optimization by adding a patch that restore this line if("${SYSPROC}" STREQUAL "" OR X86MATCH GREATER "-1") in CMakeLists.txt.
Fixes #736, fixes #681, fixes #599, fixes AnimMouse/ffmpeg-stable-autobuild#131.

Master:

ffmpeg version git-2024-05-04-38f67a3-ffmpeg-windows-build-helpers Copyright (c) 2000-2024 the FFmpeg developers
x265 [info]: HEVC encoder version 3.6+1-2f95fe7c8
x265 [info]: build info [Windows][GCC 10.2.0][64 bit] 8bit+10bit+12bit
x265 [info]: using cpu capabilities: MMX2 SSE2Fast LZCNT SSSE3 SSE4.2 AVX FMA3 BMI2 AVX2

Release 7.0:

ffmpeg version n7.0-ffmpeg-windows-build-helpers Copyright (c) 2000-2024 the FFmpeg developers
x265 [info]: HEVC encoder version 3.6+1-2f95fe7c8
x265 [info]: build info [Windows][GCC 10.2.0][64 bit] 8bit+10bit+12bit
x265 [info]: using cpu capabilities: MMX2 SSE2Fast LZCNT SSSE3 SSE4.2 AVX FMA3 BMI2 AVX2

@rdp
Copy link
Owner

rdp commented May 17, 2024

thanks

@rdp
Copy link
Owner

rdp commented May 21, 2024

A bug report upstream might be nice here too, or if not I might get to it someday :)

@AnimMouse
Copy link
Contributor Author

@rdp As of ba57a46 BtbN/FFmpeg-Builds started using x265 version 3.6, and it did not cause any problems in their build script, I wonder maybe if this problem is related to this build script, or somewhere around the compilers that this build script uses.

@rdp
Copy link
Owner

rdp commented May 29, 2024 via email

@AnimMouse
Copy link
Contributor Author

@rdp No, they are using the new one, the one that uses if(X86MATCH GREATER "-1") in the CMakeLists.txt, and their x265 build script is working properly with ASM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants