-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for SPlot #16
Bugfix for SPlot #16
Conversation
I'm unfamiliar with splot, could you give an example of its use? On Sat, Dec 8, 2012 at 9:29 PM, Алексей Заровный
|
File 3d_surface_plot.rb from examples directory. |
Tested here the patch from TheKnight and it really worked like a charm. Thanks, TheKnight! rdp, please do pull his fix. TheKnight and rdp, @arbitrary_lines.each{|line| io << line << "\n" } If it's really to be equal, shouldn't this method to_gplot just be ommited in SPlot, as it's been inherited from Plot and shall become just ipsis literis? |
Leonardo, you're right, we can just inherit this method from Plot, and functionality will be save. But separation of method implementation was making in the longest past and i can not calling reasons it. |
So should we wait for a new patch that just removes the method, or just On Tue, Dec 11, 2012 at 8:41 AM, Алексей Заровный
|
rdp, I would pull TheKnight's fix right now, basically because it solves the main problem from SPlot: it was simply just not working after the refactor. Also, it's thanks to him that we had a first solution, which then pointed the way to go. I think you should honor him and pull it right now. As for the problem of the implementation that should have been mirrored from Plot, to mend it ASAP I may present in the near future a related pull request. Then you shall merge my patch. |
rdp, Have you seen my comment above? Will you please pull TheKnight`s fix right now? |
should be there in 2.6.1 thanks! |
Hi, rdp!
In SPlot implementation was find old code remains. They has generate an exception when we used SPlot object.
I'm trying to fix this bug, but Ruby is Terra Inkognita for me. I hope i'm fixing it correct.
Yours sincerely
TheKnight
P.S:I'm sorry about my English.