Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the code into separate files #24

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dabit
Copy link

@dabit dabit commented Aug 12, 2013

While trying to figure out how the gem internals work I noticed that all the code was in a single file.

I reorganized everything into separate files and got rid of Jeweler now using the more up-to-date Bundler for releasing.

No code was changed, except for the definition of Gnuplot::Plot::QUOTED.

Used the current test suite to make sure everything is working as expected.

Later on it might be a good idea to separate the test files too.

@rdp
Copy link
Owner

rdp commented Aug 12, 2013

Ok will merge in a week or 2 if there are no objections raised, thanks!

On Mon, Aug 12, 2013 at 4:31 PM, David Padilla notifications@github.comwrote:

While trying to figure out how the gem internals work I noticed that all
the code was in a single file.

I reorganized everything into separate files and got rid of Jeweler now
using the more up-to-date Bundler for releasing.

No code was changed, except for the definition of Gnuplot::Plot::QUOTED.

Used the current test suite to make sure everything is working as expected.

Later on it might be a good idea to separate the test files too.

You can merge this Pull Request by running

git pull https://github.com/dabit/ruby_gnuplot reorganize

Or view, comment on, or merge it at:

#24
Commit Summary

  • Get rid of Jeweler
  • Extract Gnuplot::Plot to its own file
  • Extract Gnuplot::Splot to separate file
  • Extract Dataset, Array and Matrix to their own files
  • Reindent and clean the code
  • Get rid of RbConfig warning while testing

File Changes

Patch Links:

@deric
Copy link

deric commented Sep 4, 2013

+1 for code reorganization

@rdp
Copy link
Owner

rdp commented Oct 30, 2019

Shoot it has conflicts now, any chance of a rebase for me? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants