Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add array inclusion exclusion #12

Merged
merged 2 commits into from
Dec 11, 2022
Merged

Add array inclusion exclusion #12

merged 2 commits into from
Dec 11, 2022

Conversation

schlick
Copy link
Member

@schlick schlick commented Dec 10, 2022

  • Removes restriction on development dependency Bundler so v2 can be used
  • Adds array to list of element
  • Adds includes and excludes operators to comparison
  • Updates README
  • Adds CHANGELOG

@schlick
Copy link
Member Author

schlick commented Dec 10, 2022

Screen Shot 2022-12-10 at 11 50 44 pm

schlick
schlick commented Dec 10, 2022
View reviewed changes
lib/boolean_dsl/evaluator.rb
when 'includes'
left.include?(right)
when 'excludes'
!left.include?(right)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make it case insensitive? I note that == is currently not.

@schlick schlick merged commit dd57e4a into develop Dec 11, 2022
@schlick schlick deleted the add-array-inclusion-exclusion branch December 11, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidishaweddy-readytech vidishaweddy-readytech vidishaweddy-readytech approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schlick @vidishaweddy-readytech