Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warnings due to set-output #11

Closed
hynek opened this issue Oct 14, 2022 · 4 comments
Closed

Deprecation warnings due to set-output #11

hynek opened this issue Oct 14, 2022 · 4 comments
Assignees
@webknjaz
Labels
enhancement New feature or request

Comments

@hynek
Copy link

hynek commented Oct 14, 2022

GitHub has deprecated the set-output way, so I'm getting warnings in my workflows from alls-green.

Since they provided zero guidance how to fix it, I've written it down myself: https://hynek.me/til/set-output-deprecation-github-actions/

tldr: echo "::set-output name=KEY::VALUE" → echo "KEY=VALUE" >>$GITHUB_OUTPUT
@webknjaz
Copy link
Member

Yeah, I've been meaning to fix this. Thanks for the issue!

@webknjaz webknjaz self-assigned this Oct 14, 2022
@webknjaz webknjaz added the enhancement New feature or request label Oct 14, 2022
@webknjaz
Copy link
Member

@hynek FYI the actual docs section describing this is https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter. Not sure why they didn't link it directly...

webknjaz added a commit to ssbarnea/alls-green that referenced this issue Oct 14, 2022
@webknjaz
Upgrade the action output code to use env files
6eedd44 
Using the `::set-output` has been suddenly deprecated the other day,
without a clear deadline [1]. The new way of achieving the same is to
append key-value pairs to the environment file that can be located by
looking up the path recorded in the `$GITHUB_OUTPUT` environment
variable [2].

This patch implements this new mechanism. The change is not a
user-facing update and the behavior should remain the same.

Resolves re-actors#11.

[1]: https://hynek.me/til/set-output-deprecation-github-actions/
[2]: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter
webknjaz added a commit that referenced this issue Oct 14, 2022
@webknjaz
Fix the output line format to use =
768c9c2 
This is a hotfix for
6eedd443.

Ref #11
webknjaz added a commit that referenced this issue Oct 14, 2022
@webknjaz
Fix the output line format to use =
72891fe 
This is a hotfix for
6eedd443.

Ref #11
@webknjaz
Copy link
Member

@hynek they've later updated the blog post to include the examples: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/#examples.

@hynek
Copy link
Author

hynek commented Oct 21, 2022

yeah they reached out to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webknjaz webknjaz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hynek @webknjaz