Design getting urls #12

daicche · 2014-06-24T13:53:37Z

概要

検索結果ページにてどのページに遷移したかを取得する

実装案 (概略図)

model (rails)

Query (has many Pages)

query: string
session_id: string
その他諸々の検索オプション (Get the params #9)

Pages (belongs to Query)

query_id: integer
query: string (must be identical with page.query.q)
session_id: string (must be identical with page.query.session_id)
url: string
rank: integer
start: integer (2ページ目以降の場合のオフセット) (google のurl の key名が start なので)

chrome_extension

background.js

session_id = generate_session_id()
post_query(query, session_id)
send_session_id_to_content_script(session_id)

content_script.js

recieve_session_id_from_background(session_id)
post_url(query, session_id, url, rank)

TODO (実装順)

実装後

リファクタリング

chrome_extension
- post系の関数を別jsファイルにまとめてもいいかも
- オブジェクト指向
- 細かい関数 (random_id() や generate_session_id() など )を別ファイルに分離

テスト

rails
- そろそろテスト書かねば

daicche · 2014-06-24T13:54:33Z

@sosuke-k @taisho6339 ちょっと長いけど仕様レビューお願いします 🙇

daicche · 2014-06-24T13:55:52Z

@sosuke-k @taisho6339 分からないところは適宜飛ばすなり訊くなりしてください 🐾

sosuke-k · 2014-06-24T15:30:40Z

post_url(query, session_id, url, rank)
or
post_url(query, session_id, url, rank, paginated)

paginatedは？

daicche · 2014-06-24T15:49:32Z

例えば10件/ページの時に2ページ目に飛ぶと、URLが

https://www.google.co.jp/webhp?sourceid=chrome-instant&ion=1&espv=2&es_th=1&ie=UTF-8#q=hoge&safe=off&start=10

になって最後の start=10 から、rankがｎ番目ってのは分かるからページ番号は取らなくてもいいかな、と思ってる

rankだけじゃなくてページ番号も取った方がいいかな？

taisho6339 · 2014-06-25T00:51:55Z

とりあえずlgtm
not [beling] but [belong]

sosuke-k · 2014-06-25T01:25:54Z

う〜ん、ページ番号を使う場面すぐ思いつかない。

あれか、ページ番号ってマウスの位置とかスクロール量とかと同じ感じか。
まあとりあえず、いらないか。

daicche · 2014-06-25T03:03:08Z

@taisho6339 typo恥ずかしい…！直しました 💃

daicche · 2014-06-25T03:06:12Z

@sosuke-k

ページ番号ってマウスの位置とかスクロール量とかと同じ感じか。

まさにそれ！ GUI情報というかなんというかそんな感じ

daicche · 2014-06-25T10:56:14Z

実装開始します 🚋

daicche · 2014-06-25T13:05:39Z

undefined keys が入ってきたときにエラー吐くから revert した 23ba9cd

daicche · 2014-06-25T14:12:59Z

ひとまずページ情報取れるようにした
Create prototype of Getting URLs 46fb223

daicche · 2014-06-25T14:15:14Z

extention/src/content_script.js

+
+add_binding_to_page()
+
+// for ajax


検索結果ページの検索窓で再検索したときにページ遷移が起こらず(ajax)
content_script.jsが走らないので、そのajax用の処理を追加

cf.
javascript - Chrome Extension: How to reload/re-execute content script on Ajax request - Stack Overflow
http://stackoverflow.com/questions/7325701/chrome-extension-how-to-reload-re-execute-content-script-on-ajax-request

daicche · 2014-06-25T14:30:12Z

@sosuke-k @taisho6339 長くなりそうなので一旦ﾚﾋﾞｭｰお願いします 👓 👓 👓
どこまで実装したか は上の TODO(実装順) を見てください

daicche · 2014-06-25T14:34:10Z

extention/src/content_script.js

+      } else {
+        var query = parsed_url.hash.slice(1)
+      }
+      var page_data = query + '&url=' + clicked_url + '&rank=' + i


rank が 3 で start が 10 の場合、本当の rank は 10 + 3 = 13 になるから、
rank のカラム名は変えた方がいいかも。 index とか…？

サーバーにpostするのは本当のrankの方かと思ってたけど？

こういう拡張とはうまくいかないんだよね？
https://chrome.google.com/webstore/detail/autopagerize/igiofjhpmpihnifddepnpngfjhkfenbp?hl=ja

サーバーにpostするのは本当のrankの方かと思ってたけど？

了解す。

autoPagialize 的なのは普通に取得できた
https://github.com/re-born/queristory/blob/get-urls/extention/src/content_script.js#L6

で全部のページのリンク取得できてるっぽい

daicche · 2014-06-30T07:43:06Z

getting url で、一回のページ遷移でPOSTが複数回行われる · Issue #16 · re-born/queristory
#16

という問題に対応 26d8449

daicche · 2014-06-30T07:43:46Z

ページURLだけじゃなくて title も取得するように変更 92efd43

daicche · 2014-06-30T09:20:04Z

extention/src/content_script.js

+      } else {
+        var query = parsed_url.hash.slice(1)
+      }
+      chrome.extension.sendRequest({greeting: 'get_session_id'}, function(response) {


background.js に session_id を尋ねる

daicche · 2014-06-30T14:14:05Z

pagination 追加 e10ca4f

sosuke-k · 2014-06-30T17:37:27Z

うぃ

daicche · 2014-06-30T17:55:59Z

Kaminari の部分のコードが汚かったので default_scope で対応 263aff2

daicche · 2014-06-30T17:57:00Z

wrong number of arguments (2 for 1) in site.sass · Issue #155 · Compass/compass-rails
Compass/compass-rails#155
と同じエラーを吐いてて辛かったので rails の version を上げて対応 3d27b73

daicche · 2014-07-02T15:48:31Z

before

after

daicche · 2014-07-03T18:30:06Z

検索オプションの表示 (['tbm', 'as_qdr', 'lr', 'tbs', 'source']の5つ) 0ba6238

daicche · 2014-07-03T18:32:35Z

tbm: ischとかじゃなくて "画像検索" にした方がええんかなぁ

This reverts commit 283eca6f45726429b4b6c46cb458f4910a7013fc.

daicche · 2014-07-06T20:53:13Z

viewの修正 8cc4689

before

after

[WIP]Design getting urls

daicche mentioned this pull request Jun 25, 2014

Refactor some codes #13

Merged

daicche added 2 commits June 25, 2014 21:30

Divide session_id from query

1c21227

Revert controlling params

23ba9cd

daicche reviewed Jun 25, 2014
View reviewed changes

Create prototype of Getting URLs

46fb223

daicche reviewed Jun 25, 2014
View reviewed changes

daicche added 2 commits June 30, 2014 16:23

Create prototype of views

808d924

Avoid duplicated POST

26d8449

daicche reviewed Jun 30, 2014
View reviewed changes

daicche added 2 commits July 1, 2014 02:17

Get title of the clicked page

a1e6136

Bind pages to the query

bb143e7

Add default_scope to query.rb

263aff2

Update rails

3d27b73

daicche added 4 commits July 1, 2014 03:38

Add forgotten scss

8bcc7f7

Add default_scope

68d99eb

Enable link to home

76dccee

Order item closely

5383b04

Add searching options to view

0ba6238

daicche added 9 commits July 5, 2014 17:29

Add icons

3a74283

Modify session-expired time

7d28fe3

Add rank info to views

6c33bbc

Rename title of app

48bab87

Change background

7312fb3

Modify css around labels

f4c2660

Activate caching

6849f96

Revert "Activate caching"

1aa95f0

This reverts commit 283eca6f45726429b4b6c46cb458f4910a7013fc.

Avoid unnecesary breaking lines

8cc4689

daicche added 3 commits July 7, 2014 11:26

Escape "&" in page title

bb7547a

Modify visual design

15cd136

Activate caching

2844ebb

daicche added a commit that referenced this pull request Jul 14, 2014

Merge pull request #12 from re-born/get-urls

870bc97

[WIP]Design getting urls

daicche merged commit 870bc97 into master Jul 14, 2014

daicche deleted the get-urls branch July 14, 2014 11:36

daicche changed the title ~~[WIP]Design getting urls~~ Design getting urls Oct 31, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Design getting urls #12

Design getting urls #12

daicche commented Jun 24, 2014

daicche commented Jun 24, 2014

daicche commented Jun 24, 2014

sosuke-k commented Jun 24, 2014

daicche commented Jun 24, 2014

taisho6339 commented Jun 25, 2014

sosuke-k commented Jun 25, 2014

daicche commented Jun 25, 2014

daicche commented Jun 25, 2014

daicche commented Jun 25, 2014

daicche commented Jun 25, 2014

daicche commented Jun 25, 2014

daicche Jun 25, 2014

daicche commented Jun 25, 2014

daicche Jun 25, 2014

sosuke-k Jun 30, 2014

sosuke-k Jun 30, 2014

daicche Jun 30, 2014

daicche Jun 30, 2014

daicche commented Jun 30, 2014

daicche commented Jun 30, 2014

daicche Jun 30, 2014

daicche commented Jun 30, 2014

sosuke-k commented Jun 30, 2014

daicche commented Jun 30, 2014

daicche commented Jun 30, 2014

daicche commented Jul 2, 2014

daicche commented Jul 3, 2014

daicche commented Jul 3, 2014

daicche commented Jul 6, 2014

Design getting urls #12

Design getting urls #12

Conversation

daicche commented Jun 24, 2014

概要

実装案 (概略図)

model (rails)

Query (has many Pages)

Pages (belongs to Query)

chrome_extension

background.js

content_script.js

TODO (実装順)

実装後

リファクタリング

テスト

daicche commented Jun 24, 2014

daicche commented Jun 24, 2014

sosuke-k commented Jun 24, 2014

daicche commented Jun 24, 2014

taisho6339 commented Jun 25, 2014

sosuke-k commented Jun 25, 2014

daicche commented Jun 25, 2014

daicche commented Jun 25, 2014

daicche commented Jun 25, 2014

daicche commented Jun 25, 2014

daicche commented Jun 25, 2014

daicche Jun 25, 2014

Choose a reason for hiding this comment

daicche commented Jun 25, 2014

daicche Jun 25, 2014

Choose a reason for hiding this comment

sosuke-k Jun 30, 2014

Choose a reason for hiding this comment

sosuke-k Jun 30, 2014

Choose a reason for hiding this comment

daicche Jun 30, 2014

Choose a reason for hiding this comment

daicche Jun 30, 2014

Choose a reason for hiding this comment

daicche commented Jun 30, 2014

daicche commented Jun 30, 2014

daicche Jun 30, 2014

Choose a reason for hiding this comment

daicche commented Jun 30, 2014

sosuke-k commented Jun 30, 2014

daicche commented Jun 30, 2014

daicche commented Jun 30, 2014

daicche commented Jul 2, 2014

before

after

daicche commented Jul 3, 2014

daicche commented Jul 3, 2014

daicche commented Jul 6, 2014

before

after