Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in documentation #400

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

jomccr
Copy link
Contributor

@jomccr jomccr commented Aug 4, 2023

What

There is a typo in the documentation which this PR will fix.

How

Removes excess curly braces at the end of certain config blocks.

@jomccr
Copy link
Contributor Author

jomccr commented Aug 4, 2023

Actually, just saw that this is intentional. Closing the PR

@jomccr jomccr closed this Aug 4, 2023
@jomccr jomccr reopened this Aug 4, 2023
@jomccr
Copy link
Contributor Author

jomccr commented Aug 4, 2023

In the config https://docs.getre.io/latest/docs/re_data/reference/config/ there is a code block and I'm not sure if it's correct or not.

{{
    config(
      re_data_monitored=true,
      re_data_time_filter='creation_time',
      re_data_columns=['amount', 'status'],
      re_data_metrics_groups=['table_metrics', 'column_metrics'],
      re_data_metrics={'table': ['orders_obove_100'], 'column': { 'status': ['distinct_values'],
      re_data_anomaly_detector={'name': 'modified_z_score', 'threshold': 3.0} }},
      re_data_owners=['datateam']
    )
}}


select ...

Note the no closing braces after the re_data_metrics line and the double closing braces after re_data_anomaly_detector.

@mateuszklimek mateuszklimek merged commit dfdeee5 into re-data:master Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants