Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding a contact from recent calls, it goes to home screen and throws a database error. #32

Closed
RockySouthpaw opened this issue Sep 11, 2020 · 4 comments
Labels
Major Issue Game breaking. Results in an error or a core feature doesn't work. On Trello Issue is being tracked on trello

Comments

@RockySouthpaw
Copy link
Contributor

  1. Open phone
  2. Open Phone App
  3. Navigate to contacts and dial a number.
  4. End the call.
  5. Go to recent calls and right click on new contact. (Same occurs with key control.)
  6. Phone will go to home screen.

This results in this error:

[ERROR] [MySQL] [gcphone] An error happens on MySQL for query "INSERT INTO phone_users_contacts (`identifier`, `number`,`display`) VALUES('steam:110000112964a88', @number, @display)": ER_BAD_NULL_ERROR: Column 'display' cannot be null

You can also achieve this by trying to add to contacts an existing contact.

@RockySouthpaw RockySouthpaw added the Major Issue Game breaking. Results in an error or a core feature doesn't work. label Sep 11, 2020
@RockySouthpaw RockySouthpaw added On Trello Issue is being tracked on trello Major Issue Game breaking. Results in an error or a core feature doesn't work. labels Sep 25, 2020
@Archangelza1
Copy link

To Fix This You Can Make A Modal Using The Following

Add in AppelsRecents

save (numero) { if (this.id !== -1) { Modal.CreateTextModal({ title: this.IntlString('APP_PHONE_ENTER_NAME'), limit: 12 }).then(data => { this.addContact({ display: data.text, number: numero }) }) } else { console.log('No añadido') } },

And add that locale to the config.json

@RockySouthpaw
Copy link
Contributor Author

To Fix This You Can Make A Modal Using The Following

Add in AppelsRecents

save (numero) { if (this.id !== -1) { Modal.CreateTextModal({ title: this.IntlString('APP_PHONE_ENTER_NAME'), limit: 12 }).then(data => { this.addContact({ display: data.text, number: numero }) }) } else { console.log('No añadido') } },

And add that locale to the config.json

Can you PR this?

@TasoOneAsia
Copy link
Contributor

Make sure that PR also has that formatted correctly please.

@Archangelza1
Copy link

Will do

Archangelza1 added a commit to Archangelza1/Re-Ignited-Phone that referenced this issue Nov 23, 2020
@TasoOneAsia TasoOneAsia mentioned this issue Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Major Issue Game breaking. Results in an error or a core feature doesn't work. On Trello Issue is being tracked on trello
Projects
None yet
Development

No branches or pull requests

3 participants