Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #32 #74

Merged
merged 2 commits into from
Nov 28, 2020
Merged

Fixes #32 #74

merged 2 commits into from
Nov 28, 2020

Conversation

TasoOneAsia
Copy link
Contributor

Another fix for #32 that utilizes a router push to go to existing contact page to add.

What is a router and how is a router? Where can one exist with the router yet also be routed by it? ~Confucius

Uses a router push to existing contact ui
@RockySouthpaw
Copy link
Contributor

Will test later tonight. Looks good so far.

Copy link
Contributor

@RockySouthpaw RockySouthpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. There's an issue i just found unrelated to this PR where there is no hover animation when using key control while adding contacts so that will need to be fixed before next release considering the phone is entirely unusable with mouse control.

@RockySouthpaw RockySouthpaw merged commit 21cfa4a into master Nov 28, 2020
@TasoOneAsia TasoOneAsia deleted the taso-lit branch November 28, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants