fix(core/subscribe): stop rendering children when source$ switches #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue caused because I was receiving the old value from a factory
bind(id => ...)
when switching its key based on a router's param.We realised this shouldn't happen when using
Subscribe
boundaries properly, but Subscribe doesn't currently handle the case of the source stream switching.In here I add two tests: The first one tries to represent the underlying issue in Subscribe, but it turned out really contrived. So I also added a second test which better represents the issue I was having initially.