Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not secure app, able to content of files after building app #144

Open
learncodingforweb opened this issue May 21, 2023 · 1 comment
Open

Comments

@learncodingforweb
Copy link

just download template as zip file and perform followings steps

npm i
npm run dist

Operating system: Linux notebook 5.19.0-41-generic #42~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Apr 18 17:40:00 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
Version of the template: v22.0.0

Then go to folder cd secure-electron-template-master/dist/linux-unpacked/resources/
after that npx asar extract app.asar test.

Inside test folder, I am able to each and every file of electronjs and react app. Then what is secure?

@douglascayers
Copy link

Hi @learncodingforweb, this template is about implementing Electron's Security Best Practices. It's not, however, about hiding your app's source code.

Per the first sentence of this project's README, the author states:

If you are curious about what makes an electron app secure, please check out this page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants