Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron should host app from a non-file:/// origin #2

Closed
moloch-- opened this issue Jan 14, 2020 · 3 comments
Closed

Electron should host app from a non-file:/// origin #2

moloch-- opened this issue Jan 14, 2020 · 3 comments

Comments

@moloch--
Copy link

Running from a file:/// origin is insecure, for example. A simple solution

@reZach
Copy link
Owner

reZach commented Jan 14, 2020

Great, thanks for sharing this @moloch--! I'll see to it to put this code in the template.

@reZach
Copy link
Owner

reZach commented Jan 14, 2020

It seems this method of loading pages doesn't play well with the webpack dev server, I'll have to futz around with it more.

@moloch--
Copy link
Author

protocol.interceptFileProtocol can be used to limit certain uses of file:// but is less secure than doing away with it entirely.

@reZach reZach changed the title File Origin Electron should host file from a non-file:/// origin Jan 15, 2020
@reZach reZach changed the title Electron should host file from a non-file:/// origin Electron should host app from a non-file:/// origin Jan 15, 2020
@reZach reZach closed this as completed Jan 18, 2020
reZach added a commit that referenced this issue Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants