combobox: fix infinite loop bug (#481)

reach · Feb 21, 2020 · 3d1f08d · 3d1f08d
1 parent 68f528d
commit 3d1f08d
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/packages/combobox/src/index.tsx b/packages/combobox/src/index.tsx
@@ -457,7 +457,12 @@ export const ComboboxInput = forwardRefWithAs<ComboboxInputProps, "input">(
     // If they are controlling the value we still need to do our transitions, so
     // we have this derived state to emulate onChange of the input as we receive
     // new `value`s ...[*]
-    if (isControlled && controlledValue !== value) {
+    if (
+      isControlled &&
+      controlledValue !== value &&
+      // https://github.com/reach/reach-ui/issues/481
+      (controlledValue!.trim() === "" ? (value || "").trim() !== "" : true)
+    ) {
       handleValueChange(controlledValue!);
     }