Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to skip styles altogether #244

Closed
selbekk opened this issue Jul 30, 2019 · 1 comment · Fixed by #245
Closed

Ability to skip styles altogether #244

selbekk opened this issue Jul 30, 2019 · 1 comment · Fixed by #245

Comments

@selbekk
Copy link
Contributor

selbekk commented Jul 30, 2019

I love this project, and I'm using tons of its component in the apps I work for. Thanks for all of your work, efforts and dealing with all of these issues.

I typically don't use the default styles provided by the component - but I also hate the yellow console warning I get if I don't import them.

After digging through the source code (okay, it was literally opening the CSS file, but still), I found that I can add ::root { --reach-dialog: 1 } to avoid this warning. I still think this should be documented though!

Would you be open to me opening a PR documenting this "manual override"?

@venikx
Copy link

venikx commented Jul 30, 2019

Go for it I'd say. Worst case scenario Ryan says no. Not that bad, tbh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants