Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate CSS declaration #553

Merged
merged 1 commit into from Apr 15, 2020
Merged

Conversation

ddanger
Copy link
Contributor

@ddanger ddanger commented Apr 15, 2020

Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.

This pull request:

  • Creates a new package
  • Fixes a bug in an existing package
  • Adds additional features/functionality to an existing package
  • Updates documentation or example code
  • Other - removes unnecessary duplication of CSS

If creating a new package:

  • Make sure the new package directory contains each of the following, and that their structure/formatting mirrors other related examples in the project:
    • examples directory
    • src directory with an index.tsx entry file
    • At least one example file per feature introduced by the new package
    • Base styles in a style.css file (if needed by the new package)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 77d8df7:

Sandbox Source
smoosh-night-yz4nt Configuration

@ddanger
Copy link
Contributor Author

ddanger commented Apr 15, 2020

Hmm. Build failure does not seem related to my change.

@chaance chaance added the Type: Enhancement General improvements or suggestions label Apr 15, 2020
@chaance chaance merged commit 3b03ba4 into reach:master Apr 15, 2020
@ddanger ddanger deleted the remove-duplicate-css branch April 17, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement General improvements or suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants