Migrate to GitHub Actions for CI #780
Conversation
| name: Release | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
@chaance Needs attention: A GitHub secret should be created with the value of NPM_TOKEN you use.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ab726cc:
|
| @@ -21,10 +21,10 @@ cd $tmp_dir | |||
| git add -A | |||
| git commit \ | |||
| --allow-empty \ | |||
| --author "Travis CI <travis-ci@reacttraining.com>" \ | |||
| --author "GitHub CI <github-ci@reacttraining.com>" \ | |||
There was a problem hiding this comment.
@chaance Needs attention: I've made changes here for consistency, but I'd recommend creating a CI agnostic address like ci@reacttraining.com instead.
.github/workflows/ci.yml
Outdated
| run: yarn build | ||
|
|
||
| - run: echo "Deploying website to https://reach.tech/" | ||
| - run: openssl aes-256-cbc -K $encrypted_e12d3fc86b46_key -iv $encrypted_e12d3fc86b46_iv -in website-deploy-key.enc -out website-deploy-key -d |
There was a problem hiding this comment.
Needs attention: I'm not familiar with this, possibly they're also set on Travis and need to be migrated to GitHub Secrets? If so, should be updated to secrets.* format as well.
There was a problem hiding this comment.
Trying to pin down these values, but once I have these I'll update this and get it merged. In the mean time we can replace $encrypted_e12d3fc86b46_key with ${{ secrets.encrypted_e12d3fc86b46_key }} (same for the iv key).
|
This is great, thanks so much! I'll try to take a look at this and get the outstanding needs resolved this weekend. |
Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.
Test the change in your own code (Compile and run).Add or edit tests to reflect the change (Run withyarn test).Add or edit Storybook examples to reflect the change (Run withyarn start).This pull request:
Fixes #771.